Comments on: Refactoring to Patterns http://benreichelt.net/blog/2005/07/10/refactoring-to-patterns/ Tue, 18 Aug 2009 22:20:45 -0400 http://wordpress.org/?v=2.8.4 hourly 1 By: Anonymous http://benreichelt.net/blog/2005/07/10/refactoring-to-patterns/comment-page-1/#comment-377 Anonymous Mon, 11 Jul 2005 18:59:52 +0000 http://s194721765.onlinehome.us/blog/2005/07/10/refactoring-to-patterns/#comment-377 For the results of your refactoring to be verifiable, you should first re-structure the code without adding any additional functionality. Only when this is complete, and your unit tests still pass, should you add anything new. It sounds like this is pretty much what you did, but this wasn't made clear in the original post. For the results of your refactoring to be verifiable, you should first re-structure the code without adding any additional functionality. Only when this is complete, and your unit tests still pass, should you add anything new.

It sounds like this is pretty much what you did, but this wasn’t made clear in the original post.

]]> By: breichelt http://benreichelt.net/blog/2005/07/10/refactoring-to-patterns/comment-page-1/#comment-376 breichelt Mon, 11 Jul 2005 05:44:59 +0000 http://s194721765.onlinehome.us/blog/2005/07/10/refactoring-to-patterns/#comment-376 I think yudanja has it right. While I was adding some functionality, I still refactored the current implementation that returned the m3u file. That code was no longer in the page, but rather in the M3UPlaylist class. Had I stopped there it would just be refactoring, but then I went and also added functionality for the other 2 playlist types. I think yudanja has it right. While I was adding some functionality, I still refactored the current implementation that returned the m3u file. That code was no longer in the page, but rather in the M3UPlaylist class. Had I stopped there it would just be refactoring, but then I went and also added functionality for the other 2 playlist types.

]]> By: Anonymous http://benreichelt.net/blog/2005/07/10/refactoring-to-patterns/comment-page-1/#comment-375 Anonymous Mon, 11 Jul 2005 04:53:44 +0000 http://s194721765.onlinehome.us/blog/2005/07/10/refactoring-to-patterns/#comment-375 I disagree with the previous post to a point. While by true definition it might not be refactoring how many developers simply refactor code just to refactor. Typically you are refactoring b/c what you are trying to do can't be done well with the current implimentation. Don't be so picky. It is refactoring but the developer is also adding more functionality. I disagree with the previous post to a point. While by true definition it might not be refactoring how many developers simply refactor code just to refactor. Typically you are refactoring b/c what you are trying to do can’t be done well with the current implimentation. Don’t be so picky. It is refactoring but the developer is also adding more functionality.

]]> By: Anonymous http://benreichelt.net/blog/2005/07/10/refactoring-to-patterns/comment-page-1/#comment-374 Anonymous Sun, 10 Jul 2005 20:50:37 +0000 http://s194721765.onlinehome.us/blog/2005/07/10/refactoring-to-patterns/#comment-374 As you are adding new functionality, this isn't refactoring! As you are adding new functionality, this isn’t refactoring!

]]>